Home Developer Coding Problems: One Less Exception

Coding Problems: One Less Exception

Author

Date

Category

java.util.NoSuchElementException: No value found for ‘USD’
at scala.Enumeration.withName(Enumeration.scala:124)

Dammit! I hate it when code blows in production.
For some cases there’s just no tests or static analysis that can cover you.

This is one of those cases. Calling the withName method with an inexistent value in an Enumeration will blow up. Sure, it throws an Exception, but since Scala has unchecked exceptions, the compiler won’t warn you.

https://gist.github.com/mrfyda/ad94180cd00613cf314b

Unfortunately, it wasn’t the first time we had exactly this problem, so we agreed to start avoiding the withName method and writing it as:

https://gist.github.com/mrfyda/d9241e947c1600866069

Since find returns an Option, the code needs to be ready to deal with the possibility of a non existing value.

We also want all of our users to stay safe, so today we’re adding a new code pattern: Prohibit withName on Enumeration.
You can check your code for this issue and fix it before it blows in production!


Edit: We just published an ebook: “The Ultimate Guide to Code Review” based on a survey of 680+ developers. Enjoy!


About Codacy

Codacy is used by thousands of developers to analyze billions of lines of code every day!

Getting started is easy – and free! Just use your  GitHub, Bitbucket or Google account to sign up.

GET STARTED

LEAVE A REPLY

Please enter your comment!
Please enter your name here

Subscribe to our newsletter

To be updated with all the latest news, offers and special announcements.

Recent posts

What to expect after adopting a code review tool like Codacy

In a previous article, we’ve covered how much technical debt and code quality issues are costing you and how Codacy can...

Why our customers made the switch to Codacy

Software engineering teams across several industries are always looking for the best tools to use on their CI/CD pipelines. Here are...

Flexible vacation days: our commitment to employees’ well-being

At Codacy, teams and individuals are encouraged to manage their own time. We want to build an environment of trust that...

Don’t drop the ball: Keeping your code up to standards

On April 27th, we did a webinar called Don’t drop the ball: Keeping your code up to standards. 

April Product Update 🚀

Hi there 👋, Here are some exciting news from April! We have a major announcement, so keep...